Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lambdas in anonymous classes referencing parameters from the root method #423

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Fix lambdas in anonymous classes referencing parameters from the root method #423

merged 2 commits into from
Aug 24, 2024

Conversation

coehlrich
Copy link
Contributor

Fixes cases where a lambda in an anonymous class that is in a method references a parameter from the root method.

@jaskarth jaskarth added Priority: High High priority Subsystem: Variables Anything concerning variables, types, assignments, and casting bugfix Fixes a bug regression Used to work before, but doesn't now labels Aug 24, 2024
jaskarth
jaskarth approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thank you!

@jaskarth jaskarth merged commit 842371b into Vineflower:develop/1.11.0 Aug 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaskarth jaskarth jaskarth approved these changes

@Machine-Maker Machine-Maker Machine-Maker approved these changes

Assignees
No one assigned
Labels
bugfix Fixes a bug Priority: High High priority regression Used to work before, but doesn't now Subsystem: Variables Anything concerning variables, types, assignments, and casting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coehlrich @Machine-Maker @jaskarth