Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPG key #299

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Fix GPG key #299

merged 3 commits into from
Aug 13, 2024

Conversation

VincentLanglet
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bf36c83) to head (90c53b4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #299   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       733       733           
===========================================
  Files             64        64           
  Lines           2286      2286           
===========================================
  Hits            2286      2286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VincentLanglet
Copy link
Owner Author

I'm new with phar.

Does your issue (phar-io/phar.io#154 (comment)) will be fixed with
https://github.com/VincentLanglet/Twig-CS-Fixer/actions/runs/10372550266/artifacts/1807176807 @thePanz ?

Or I have to make a release in order to know this.

@VincentLanglet
Copy link
Owner Author

I'm new with phar.

Does your issue (phar-io/phar.io#154 (comment)) will be fixed with VincentLanglet/Twig-CS-Fixer/actions/runs/10372550266/artifacts/1807176807 @thePanz ?

Or I have to make a release in order to know this.

Or maybe @llaville you can help me confirming this PR will fix the issue ?

@llaville
Copy link
Contributor

@VincentLanglet I'm not sure I can really help you on this purpose, because I did not yet implemented a such solution.

BTW, I've noticed that the official BOX project have a same solution: see https://github.com/box-project/box/blob/main/.github/workflows/release.yaml
Hope it will help you a bit !

@VincentLanglet VincentLanglet marked this pull request as ready for review August 13, 2024 16:27
@VincentLanglet VincentLanglet merged commit ac11c63 into main Aug 13, 2024
17 checks passed
@VincentLanglet VincentLanglet deleted the fix-sign branch August 13, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants