Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix soft_reset startup time #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix soft_reset startup time #39

wants to merge 1 commit into from

Conversation

Remmirad
Copy link

Changes delay_ns to delay_ms in lib::AsyncBME280Common::soft_reset to actually make the startup delay 2 ms as stated in the comment. 2ns is definitely to short.

@kbleeke
Copy link

kbleeke commented Feb 24, 2024

This fixed #38 for me. Tested on rp-pico with embassy async i2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacksonn97 jacksonn97 jacksonn97 approved these changes

@kbleeke kbleeke kbleeke approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Remmirad @kbleeke @jacksonn97