Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mataformat): Notify about features supported in the Mata library #471

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

Adda0
Copy link
Collaborator

@Adda0 Adda0 commented Nov 22, 2024

This PR notifies the user that the Mata library currently only supports NFAs. Rewriting the AUTOMATAFORMAT.md file as well as updating the supported features is left for later PRs.

@Adda0 Adda0 requested a review from jurajsic November 22, 2024 11:51
@jurajsic
Copy link
Member

Can you also try the NFA examples in the format, to see if we actually support them? I am not sure if we support %Alphabet-utf (and for example, we for sure do not support %Alphabet-numbers even though it is mentioned that it is one type of alphabet)

@Adda0
Copy link
Collaborator Author

Adda0 commented Nov 22, 2024

I have added a note about not supporting additional features of the format. That should cover all the cases. Basically, for now the format says "This is what we want, but we may not support anything from this." It simply needs a whole rewrite. This includes the examples, too.

@Adda0
Copy link
Collaborator Author

Adda0 commented Nov 22, 2024

I have a task made for rewriting the format. I will add this there to not forget.

@Adda0 Adda0 merged commit 041614a into devel Nov 22, 2024
18 checks passed
@Adda0 Adda0 deleted the Adda0-patch-1 branch November 22, 2024 12:41
hiraethese pushed a commit to hiraethese/mata that referenced this pull request Dec 19, 2024
…eriFIT#471)

fix(mataformat): Notify about features supported in the Mata library #patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants