-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default RE2 encoding to Latin1 #461
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #461 +/- ##
==========================================
+ Coverage 72.15% 73.67% +1.51%
==========================================
Files 30 30
Lines 3714 4251 +537
Branches 847 968 +121
==========================================
+ Hits 2680 3132 +452
- Misses 738 771 +33
- Partials 296 348 +52 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will believe you that the decoding bit shifts and other bit operations are correct. Other than that, it seems alright. I will merge the code now, and we can test the issues waiting for this PR.
This PR: