Simplify build commands with modern cmake options #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajsic
approved these changes
Oct 5, 2023
Adda0
force-pushed
the
simplify_makefile
branch
from
0197ed1 to
a5e0dce
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #362 +/- ##
=======================================
Coverage 71.68% 71.68%
=======================================
Files 30 30
Lines 3617 3617
Branches 830 830
=======================================
Hits 2593 2593
Misses 735 735
Partials 289 289 ☔ View full report in Codecov by Sentry. |
tfiedor
approved these changes
Oct 6, 2023
Adda0
force-pushed
the
simplify_makefile
branch
from
a5e0dce to
1e51345
Compare
Adda0
force-pushed
the
simplify_makefile
branch
from
1e51345 to
6782265
Compare
|
I addressed the suggestions. I will merge the PR once the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies Makefile with modern CMake command line options.
mkdir -p $(BUILD_DIR)does not need to be called sincecmake -B $(BUILD_DIR)creates the directory by itself if the directory is missing.Target
release-debuginfois added which is a release build with debug information, useful for profiling, debugging, etc.