-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring mintermization to MintermizationDomain #355
base: devel
Are you sure you want to change the base?
Conversation
… the bloody bdd manager
…rehensible for stupid computer scientists
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #355 +/- ##
==========================================
+ Coverage 71.70% 73.16% +1.45%
==========================================
Files 30 32 +2
Lines 3644 3536 -108
Branches 843 805 -38
==========================================
- Hits 2613 2587 -26
+ Misses 736 649 -87
- Partials 295 300 +5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me overall. @kilohsakul Is this what you envisioned?
When the PR is finished, @tfiedor or I will fix the binding before merging the PR. |
Co-authored-by: David Chocholatý <[email protected]>
Co-authored-by: David Chocholatý <[email protected]>
Co-authored-by: Tomas Fiedor <[email protected]>
This PR indtroduces the following changes:
BDDDomain
which encapsulatesBDD
s and is an example for the possible future domains for mintermization.