Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring mintermization to MintermizationDomain #355

Draft
wants to merge 20 commits into
base: devel
Choose a base branch
from

Conversation

martinhruska
Copy link
Member

@martinhruska martinhruska commented Sep 29, 2023

This PR indtroduces the following changes:

  • Mintermization is now parametrized by a template defining mintermization domain, so called MintermizationDomain.
  • Creates the data structure BDDDomain which encapsulates BDDs and is an example for the possible future domains for mintermization.
  • Refactor algorithms to work over this domain.
  • Removes AFA from mintermization.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (5143cde) 71.70% compared to head (eac2b49) 73.16%.
Report is 46 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #355      +/-   ##
==========================================
+ Coverage   71.70%   73.16%   +1.45%     
==========================================
  Files          30       32       +2     
  Lines        3644     3536     -108     
  Branches      843      805      -38     
==========================================
- Hits         2613     2587      -26     
+ Misses        736      649      -87     
- Partials      295      300       +5     
Files Coverage Δ
include/mata/parser/bdd-domain.hh 100.00% <100.00%> (ø)
include/mata/parser/inter-aut.hh 89.74% <100.00%> (ø)
src/bdd-domain.cc 100.00% <100.00%> (ø)
src/mintermization.cc 0.00% <ø> (-34.56%) ⬇️
src/parser.cc 82.06% <100.00%> (ø)
src/inter-aut.cc 65.16% <90.90%> (+0.31%) ⬆️
include/mata/parser/mintermization.hh 66.66% <66.26%> (+41.66%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me overall. @kilohsakul Is this what you envisioned?

include/mata/parser/mintermization.hh Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
tests/mintermization.cc Show resolved Hide resolved
tests/mintermization.cc Outdated Show resolved Hide resolved
src/mintermization.cc Outdated Show resolved Hide resolved
include/mata/parser/bdd-domain.hh Outdated Show resolved Hide resolved
include/mata/parser/mintermization.hh Outdated Show resolved Hide resolved
include/mata/parser/mintermization.hh Outdated Show resolved Hide resolved
@Adda0
Copy link
Collaborator

Adda0 commented Oct 2, 2023

When the PR is finished, @tfiedor or I will fix the binding before merging the PR.

@Adda0 Adda0 requested a review from tfiedor October 2, 2023 12:16
include/mata/parser/bdd-domain.hh Outdated Show resolved Hide resolved
include/mata/parser/mintermization.hh Outdated Show resolved Hide resolved
include/mata/parser/mintermization.hh Outdated Show resolved Hide resolved
include/mata/parser/mintermization.hh Outdated Show resolved Hide resolved
@Adda0 Adda0 marked this pull request as draft October 25, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants