Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: parameters description #7

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Readme: parameters description #7

merged 3 commits into from
Jan 16, 2025

Conversation

vhavlena
Copy link
Collaborator

@vhavlena vhavlena commented Dec 30, 2024

This PR adds description of basic parameters to README file.

@vhavlena
Copy link
Collaborator Author

@OndrejAlexaj Ondra, could you check if I covered all relevant parameters, please?

@vhavlena vhavlena linked an issue Dec 31, 2024 that may be closed by this pull request
@OndrejAlexaj
Copy link
Collaborator

@OndrejAlexaj Ondra, could you check if I covered all relevant parameters, please?

preproc_incl_{A,B} can also be assigned value medium. And for macrostate pruning we also have parameters: early=yes|no, early_plus=yes|noand gfee=yes|no.

@vhavlena vhavlena requested a review from OndrejAlexaj January 1, 2025 19:18
@vhavlena
Copy link
Collaborator Author

vhavlena commented Jan 3, 2025

@OndrejAlexaj Could you check if it is ok, please?

Copy link
Collaborator

@OndrejAlexaj OndrejAlexaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preproc_incl_{A,B} can also be assigned value medium. And for macrostate pruning we also have parameters: early=yes|no, early_plus=yes|noand gfee=yes|no.

@vhavlena vhavlena merged commit 3dc3822 into devel Jan 16, 2025
2 checks passed
@vhavlena vhavlena deleted the readme-params branch January 16, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters for input reduction
2 participants