allow a host to have a path #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
commented
Aug 8, 2023
nilsnolde
commented
Aug 8, 2023
jcoupey
reviewed
Aug 12, 2023
|
This part of the code is not touched really often, but I just merged a couple PR that introduced conflicts here. Sorry for the inconvenience... |
|
Thanks for the review @jcoupey , comments are addressed and master merged. |
jcoupey
approved these changes
Aug 12, 2023
| index = host.find('/'); | ||
| if (index != std::string::npos) { | ||
| path = host.substr(index + 1) + "/"; | ||
| host = host.substr(0, index); |
There was a problem hiding this comment.
Nitpicking: this is making a copy while we could simply host.erase(index).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
fixes #966
Now this can be done (note, we're robust to (non-)existing trailing slash in the path):
Tasks
CHANGELOG.md(remove if irrelevant)