rewrote link url checker logic

VKCOM · Jul 28, 2024 · 5cfd146 · 5cfd146
1 parent 38a94b1
commit 5cfd146
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/rules/parser.go b/src/rules/parser.go
@@ -349,7 +349,7 @@ func (p *parser) parseRuleInfo(st ir.Node, labelStmt ir.Node, proto *Rule) (Rule
 }
 
 func isURL(str string) bool {
-	re := regexp.MustCompile(`^(https?|ftp)://[^\s/$.?#].\S*$`)
+	re := regexp.MustCompile(`^((https?|ftp)://)?[^\s/$.?#].[^\s]*$`)
 	return re.MatchString(str)
 }
 

diff --git a/src/tests/rules/rules_test.go b/src/tests/rules/rules_test.go
@@ -338,7 +338,7 @@ func TestLinkTag(t *testing.T) {
  * @name emptyIf
  * @warning suspicious empty body of the if statement
  * @scope local
- * @link https://goodrule.com
+ * @link goodrule.com
  */
 if ($_);
 `
@@ -354,7 +354,7 @@ function f() {
 `)
 
 	test.Expect = []string{
-		` | More about this rule: https://goodrule.com`,
+		` | More about this rule: goodrule.com`,
 	}
 	test.RunRulesTest()
 }