Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popper): add prop getFloatingElementHiddenStyles #8126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Нужно добавить возможность управлять стилями всплывающего элемента при использовании свойства hideWhenReferenceHidden

Изменения

  • Добавил свойство getFloatingElementHiddenStyles для получения стилей при скрытии/появлении всплывающего элемента
  • Добавил тесты функционала

Release notes

Улучшения

  • Для компонентов Popper, Popover и Tooltip добавлено свойство getFloatingElementHiddenStyles для управления стилями всплывающего элемента при скрытии/появлении при использовании свойства hideWhenReferenceHidden

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 27, 2024 08:03
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

size-limit report 📦

Path Size
JS 390.04 KB (+0.15% 🔺)
JS (gzip) 118.34 KB (+0.11% 🔺)
JS (brotli) 97.5 KB (+0.26% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 342.61 KB (0%)
CSS (gzip) 42.45 KB (0%)
CSS (brotli) 33.82 KB (0%)

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit dbbb91d

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.55%. Comparing base (23acf45) to head (dbbb91d).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/lib/floating/functions.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8126   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files         398      398           
  Lines       11332    11361   +29     
  Branches     3733     3747   +14     
=======================================
+ Hits        10828    10856   +28     
- Misses        504      505    +1     
Flag Coverage Δ
unittests 95.55% <92.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Интересное решение 🤔

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 5, 2025
@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: hideWhenReferenceHidden колбэк для Popper
3 participants