Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HorizontalScroll, CardScroll): fix rtl view #8110

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Сейчас компонент HorizontalScroll работает неправильно в rtl, а с ним вместе соответственно компонент CardScroll тоже работает некорректно

Изменения

  • Доработана логика компонента HorizontalScroll в режиме rtl
  • Доработана логика компонента CardScroll в режиме rtl

Release notes

Улучшения

  • HorizontalScroll: Добавлена поддержка rtl
  • CardScroll: Добавлена поддержка rtl

Copy link

codesandbox-ci bot commented Dec 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

size-limit report 📦

Path Size
JS 390.27 KB (+0.09% 🔺)
JS (gzip) 118.53 KB (+0.11% 🔺)
JS (brotli) 97.5 KB (+0.1% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 343.57 KB (+0.08% 🔺)
CSS (gzip) 42.56 KB (+0.09% 🔺)
CSS (brotli) 33.95 KB (+0.21% 🔺)

Copy link
Contributor

github-actions bot commented Dec 19, 2024

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

github-actions bot commented Dec 19, 2024

👀 Docs deployed

Commit 1f2054b

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.59%. Comparing base (ba6b9c4) to head (1f2054b).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...ages/vkui/src/components/CardScroll/CardScroll.tsx 82.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8110      +/-   ##
==========================================
+ Coverage   95.55%   95.59%   +0.03%     
==========================================
  Files         398      398              
  Lines       11351    11725     +374     
  Branches     3741     3959     +218     
==========================================
+ Hits        10847    11209     +362     
- Misses        504      516      +12     
Flag Coverage Δ
unittests 95.59% <89.74%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 3, 2025
@vkcom-publisher
Copy link
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@EldarMuhamethanov EldarMuhamethanov removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants