-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook update #46
Notebook update #46
Conversation
changed required tels from 3 to 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments. It's all minor stuff that I can do
type : "PL" | ||
#array of [normalization, spectral index] | ||
# Spectral fit parameters (initial guess) - for power law: array of [normalization, spectral index] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Add units to normalization (I'll do this)
aeff_max_percent: 0.01 | ||
offset_max: 1.75 | ||
# Safe energy threshold (as a %) for effective area - ED doesn't use this, so it's set fairly small | ||
aeff_max_percent: 0.1 | ||
#exclusion regions are lists of lists of [[SkyCoord, radius], [SkyCoord, radius], ...] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a comment to explicitly say degrees
I'm getting an error when running the analysis notebook on this cell:
|
Implemented the corrected significance and alpha outputs from ExcessMapEstimator using correlate_off = False (see gammapy/gammapy#5245).
This will create artifacts in sky maps unless you are using the maps.py file in gammapy that is currently part of gammapy/gammapy#5270. The fix should be "officially" implemented in gammapy 1.3 (coming very soon).
Additionally, some bug & docs fixes to the notebook.