Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v492.0 base development branch #291

Draft
wants to merge 77 commits into
base: main
Choose a base branch
from
Draft

v492.0 base development branch #291

wants to merge 77 commits into from

Conversation

GernotMaier
Copy link
Member

@GernotMaier GernotMaier commented Dec 27, 2024

Main goals for v492:

  • improve efficiency of IRF calculation (lower storage footprint; introduce possibility to re-calculate all stereo parameters (MSCW, MSCL, emission height, direction, core, energy) on the mscw_energy level for 3-telescope events from 4-telescope MC simulations. This is for MC events only and used to simplify and accelerate the analysis required for the generation of effective areas.)
    • script improvement to run mscw_energy and effective area code for 4 and 3-telescope arrays in one job.
  • bug fixes related to 3-telescope analysis
  • soft cuts
  • efficiency improvements in number of calls to TMVA evaluator in gamma/hadron cuts: interpolation of MVA cuts
    • (UMA2 skymap).

Changes:

  • reduced storage impact of mscw_energy branch (mostly due to change of doubles to floats; removal of unused variables); reduction is on storage requirements is ~25%.
  • fine-tuning of docker build scripts to improve build efficiency
  • add code to redo stereo reconstruction to CData.cpp. Functions are named reconstruct_3tel_images*
  • generalized calculation of MSCW, MSCL, MWR, MWL variables in new classes VMeanScaledVariables
  • allow to recalculate dispBDTDirection and dispBDTEnergy in VDispAnalyzer from values per image
  • several important improvements and bug fixes in stereo reconstruction code in VTableLookupDataHandler:
    • Chi2 from direction reconstruction not correctly filled from showerpars trees
    • bug fix in setting of NImages and selected telescopes for 3-telescope runs (function fill_selected_images_before_redo_stereo_reconstruction)
  • clarified that Erec is from dispBDTEnergy while ErecS is from simple lookup table reconstruction. Change default values for EnergyReconstructionMethod to Erec (method ID 0) for anasum and effective area code.
  • introduced consistent naming of tree reader support classes. Moved them from .C to .cpp. Removed obsolete code in these files.
  • removed Version from CData class initialize (as it is read from tree doc string).
  • removal of CEffFit.h classes (not used anywhere)
  • bug fix in SizeSecondMax calculation for 3-tel reconstruction using in mscw_energy the rec_id option (no image selection was applied)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant