-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v492.0 base development branch #291
Draft
GernotMaier
wants to merge
77
commits into
main
Choose a base branch
from
v492-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v492-dev1 improve efficiency of MVA
492 dev1 - Maintenance; sofa update
v492.0 - 3tel images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goals for v492:
mscw_energy
level for 3-telescope events from 4-telescope MC simulations. This is for MC events only and used to simplify and accelerate the analysis required for the generation of effective areas.)mscw_energy
and effective area code for 4 and 3-telescope arrays in one job.gamma/hadron cuts
: interpolation of MVA cutsChanges:
mscw_energy
branch (mostly due to change of doubles to floats; removal of unused variables); reduction is on storage requirements is ~25%.CData.cpp
. Functions are namedreconstruct_3tel_images*
VMeanScaledVariables
dispBDTDirection
anddispBDTEnergy
inVDispAnalyzer
from values per imageVTableLookupDataHandler
:Chi2
from direction reconstruction not correctly filled fromshowerpars
treesNImages
and selected telescopes for 3-telescope runs (functionfill_selected_images_before_redo_stereo_reconstruction
)Erec
is fromdispBDTEnergy
whileErecS
is from simple lookup table reconstruction. Change default values forEnergyReconstructionMethod
toErec
(method ID0
) foranasum
andeffective area
code..C
to.cpp
. Removed obsolete code in these files.Version
fromCData
class initialize (as it is read from tree doc string).CEffFit.h
classes (not used anywhere)mscw_energy
therec_id
option (no image selection was applied)