-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial code for merge CSV cloud function. #18
Conversation
202509c
to
acec393
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm can this config be shared between this new fucntion and the existing cloud function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If want to trigger them separately (i.e., only run the relevant actions when files in each respective function are updated) then that's not possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm the submitted code should pass all the checks and the checks are pretty quick to run, I would prefer a single file to reduce overhead for USL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would look like two jobs in the same file, but the jobs would be identical to now, and I don't think having a single long file is significantly less complex than two shorter files. (The requirements for both functions are different, so we can't run all the actions in the same job.)
Initial code for merge CSV cloud function.
Also, refactor github workflows.