Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial code for merge CSV cloud function. #18

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Initial code for merge CSV cloud function. #18

merged 3 commits into from
Jun 14, 2024

Conversation

sylmak
Copy link
Collaborator

@sylmak sylmak commented Jun 11, 2024

Initial code for merge CSV cloud function.

Also, refactor github workflows.

@sylmak sylmak force-pushed the merge-csv branch 4 times, most recently from 202509c to acec393 Compare June 11, 2024 18:29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm can this config be shared between this new fucntion and the existing cloud function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If want to trigger them separately (i.e., only run the relevant actions when files in each respective function are updated) then that's not possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm the submitted code should pass all the checks and the checks are pretty quick to run, I would prefer a single file to reduce overhead for USL

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would look like two jobs in the same file, but the jobs would be identical to now, and I don't think having a single long file is significantly less complex than two shorter files. (The requirements for both functions are different, so we can't run all the actions in the same job.)

@sylmak sylmak merged commit 32e79df into main Jun 14, 2024
1 check passed
@sylmak sylmak deleted the merge-csv branch June 20, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants