Skip to content

Commit

Permalink
Merge pull request #331 from UrbanOS-Public/1143-fix-plotly-link-sepa…
Browse files Browse the repository at this point in the history
…rator-bar

Better looking divider between help links
  • Loading branch information
jfolk2015 authored Apr 26, 2023
2 parents 2a58f7d + cfdb627 commit 97cd224
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 11 deletions.
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@smartcitiesdata/react-discovery-ui",
"version": "2.1.36",
"version": "2.1.37",
"description": "React component for dataset discovery UI",
"main": "./lib/ReactDiscoveryUI.js",
"repository": {
Expand Down
7 changes: 5 additions & 2 deletions src/pages/dataset-view/dataset-view.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,12 @@ export default class extends Component {
}
{this.isNotDatasetDetailsTab() &&
<>
<a role="link" className='helpLink primary-color' target='_blank' href='https://en.wikipedia.org/wiki/SQL_syntax'>SQL Help&nbsp;&nbsp;</a>
<a role="link" className='helpLink primary-color' target='_blank' href='https://en.wikipedia.org/wiki/SQL_syntax'>SQL Help</a>
{this.isVisualizationEnabled() &&
<a role="link" id='plotlyhelp' className='helpLink primary-color' target='_blank' href='https://plotly.com/chart-studio-help/tutorials/#basic'>Plot.ly Help</a>
<>
<p>|</p>
<a role="link" id='plotlyhelp' className='helpLink primary-color' target='_blank' href='https://plotly.com/chart-studio-help/tutorials/#basic'>Plot.ly Help</a>
</>
}

</>}
Expand Down
6 changes: 1 addition & 5 deletions src/pages/dataset-view/dataset-view.scss
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ dataset-view {
padding-left: 15px;
}

.helpLink:first-of-type:after {
content: "|";
}

.react-tabs__tab-list {
border-bottom: 0;
box-shadow: 0px 1px 3px $light-grey;
Expand Down Expand Up @@ -96,4 +92,4 @@ dataset-view {
loading-element {
@include default-loading-icon();
}
}
}

0 comments on commit 97cd224

Please sign in to comment.