feat(java): expose core version in java engine layer #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
commented
Jan 14, 2025
| @@ -141,6 +141,11 @@ public List<FeatureDef> listKnownToggles() throws YggdrasilError { | |||
| return response.getValue(); | |||
| } | |||
|
|
|||
| public static String getCoreVersion() { | |||
There was a problem hiding this comment.
We're receiving a static pointer in this function so no need to clean up
sighphyre
commented
Jan 14, 2025
| @@ -31,6 +31,7 @@ pub type CompiledState = HashMap<String, CompiledToggle>; | |||
|
|
|||
| pub const SUPPORTED_SPEC_VERSION: &str = "5.1.9"; | |||
| const VARIANT_NORMALIZATION_SEED: u32 = 86028157; | |||
| pub const CORE_VERSION: &str = env!("CARGO_PKG_VERSION"); | |||
There was a problem hiding this comment.
Bake the semver defined in the cargo toml file into a constant in the binary itself
sighphyre
commented
Jan 14, 2025
| Context, EngineState, EvalWarning, ExtendedVariantDef, ToggleDefinition, CORE_VERSION, | ||
| }; | ||
|
|
||
| static CORE_VERSION_CSTRING: std::sync::LazyLock<CString> = |
There was a problem hiding this comment.
I think the expect here is okay since this should only cause problems if this uses an escape character to inject a nul byte and this always a semver string which can't have escape characters.
For the Unrusted:
CStrings are heap allocated so we can't just make constants out of them. So we wrap this in a LazyLock, which sets the value the first time and thereafter just retrieves it. A singleton, if you will
For the Rusted:
Look ma, no once_cell!
…o something horrible (#200)
sighphyre
added a commit
that referenced
this pull request
Jan 14, 2025
…ods can be exposed and do memory management that should work on Java 18 and above (#198) * refactor(java): rework java engine so that static methods can be exposed cleanly * feat(java): expose core version in java engine layer (#199) * fix(java): force native encoding to utf-8 so windows doesn't set it to something horrible (#200)
sighphyre
added a commit
that referenced
this pull request
Jan 14, 2025
…#197) * feat(java): expose list_known_features * refactor(java):separate resposibilities on java engine so static methods can be exposed and do memory management that should work on Java 18 and above (#198) * refactor(java): rework java engine so that static methods can be exposed cleanly * feat(java): expose core version in java engine layer (#199) * fix(java): force native encoding to utf-8 so windows doesn't set it to something horrible (#200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the Yggdrasil version in the Java layer so we can always know what binary the Java engine is shipped with. Generally useful for other engines too