feat: delta processing implementation #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| warnings: &mut Vec<EvalWarning>, | ||
| ) -> CompiledToggle { | ||
| let rule = upgrade(&toggle.strategies.clone().unwrap_or_default(), segment_map); | ||
| let variant_rule = compile_variant_rule(&toggle, segment_map); |
Check warning
Code scanning / clippy
this expression creates a reference which is immediately dereferenced by the compiler Warning
There was a problem hiding this comment.
Fair, should sort this out before merging but not a biggie
sjaanus
changed the title
sighphyre
reviewed
Jan 8, 2025
unleash-yggdrasil/src/lib.rs
Outdated
| @@ -236,6 +245,24 @@ pub struct ResolvedToggle { | |||
| } | |||
|
|
|||
| impl EngineState { | |||
| fn take_delta(&mut self, delta: &ClientFeaturesDelta) -> Option<Vec<EvalWarning>> { | |||
There was a problem hiding this comment.
Want to make this public so it can be used? That should also sort out the Clippy lint
sighphyre
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yggdrasil implementation how we initialize from delta or apply delta on existing data.