add/remove muted attribute #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless the attribute is actually on the element, the browser doesn't recognise it as muted and won't autoplay. Also added missing volumechange handler to audio
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
requested changes
Jan 16, 2025
Comment on lines
112
to
116
| if (muted) { | ||
| that.$media.attr("muted", ""); | ||
| } else { | ||
| that.$media.removeAttr("muted"); | ||
| } |
There was a problem hiding this comment.
This will add or remove the muted attribute when the mute is applied from outside of MediaElement, but it will not have the same effect if the volume is changed from inside MediaElement. For example, if I click the external mute control, the audio element gets a "muted" attribute. But if I then raise the volume in the player itself, the attribute remains. Do we need to account for this in the volumechange event handlers for consistency?
demiankatz
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless the attribute is actually on the element, the browser doesn't recognise it as muted and won't autoplay. Also added missing volumechange handler to audio