-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to vendor a repo #964
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #964 +/- ##
==========================================
+ Coverage 81.93% 82.59% +0.65%
==========================================
Files 132 129 -3
Lines 4861 4808 -53
==========================================
- Hits 3983 3971 -12
+ Misses 878 837 -41 ☔ View full report in Codecov by Sentry. |
77ca216
to
12e97ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bunch of typos, another bunch of formatting issues, see below.
A suggestion for better readability: uppercase the GIVING and RECEIVING.
I would also suggest to replace the "giving-receiving" pair with f.e. "in-out" or "origin-target" for a better clarity IMO
I went with ORIGIN and TARGET. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is definitely good to have a how-to for this, but even though this operation has been done once for argus
and argus-htmx-frontend
, it strikes me as a strange thing to have generic documentation for in Argus - it's not exactly documentation of Argus itself, or even some maintenance operation we can expect to be doing regularly for Argus.
I feel like this would more appropriately belong in some external knowledge base or wiki for our team.
As long as it is public and I can find it when I need it. This is useful for more than our team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See a comment below about heading levels
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Still not sure this really belongs in the Argus docs, though. Maybe we need our own tech blog? ;)
No description provided.