-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter incident by tags using simple input field #1114
base: master
Are you sure you want to change the base?
Conversation
Test results 10 files 1 060 suites 38m 16s ⏱️ Results for commit dc7b986. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See styling RFC below. Works otherwise
When I try to run this, I very quickly run out of memory so badly that I either need to kill the test webserver or boot my machine. I suspect it is due to me testing with a copy of production data; our production currently has more than 14000 different, unique tags. I do not recommend attempting to cram 14000+ tags into a single html file as drop-down options. I suspect type-ahead is an absolute necessity for tags if we are to only accept valid tags. Also in production we are only using 30 different Tag keys. We could preload just the keys and have ppl select twice: first the key, then the value. Get the number of values relative to keys by running
in the dbshell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot work as is with production data, too many tags.
On my machine the limit seems to be somewhere between 5000 and 7500 tags. 5000 tags eventually loads, 7500 always croaks. |
045dbf7
to
a305a25
Compare
a305a25
to
dc7b986
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
- Coverage 79.67% 79.62% -0.05%
==========================================
Files 141 141
Lines 5288 5292 +4
==========================================
+ Hits 4213 4214 +1
- Misses 1075 1078 +3 ☔ View full report in Codecov by Sentry. |
Closes #1044.
This is the simplest implementation without any error handling, since I am working on implementing active search for tags.
The tags need to be entered in the format
a=b, c=d
.