Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to tox.ini to build sphinx docs #1107

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

johannaengland
Copy link
Contributor

Closes #1083.

@johannaengland johannaengland added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label Jan 3, 2025
@johannaengland johannaengland self-assigned this Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (4cedd03) to head (152caf2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1107   +/-   ##
=======================================
  Coverage   79.83%   79.83%           
=======================================
  Files         145      145           
  Lines        5267     5267           
=======================================
  Hits         4205     4205           
  Misses       1062     1062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work unless tox is run inside a virtualenv

@johannaengland
Copy link
Contributor Author

This does not work unless tox is run inside a virtualenv

I can run it outside a virtualenv without any problems

@johannaengland johannaengland requested a review from hmpf January 6, 2025 14:19
Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me if I remove the PYTHONPATH-line.

@hmpf
Copy link
Contributor

hmpf commented Jan 7, 2025

Also, I wonder if we ought to have a settings-file for cases like this, with lost of things hardcoded. "dev" does too much and "backend" demands certain settings as environment variables.

It seems to work using "base" though.

@johannaengland johannaengland requested a review from hmpf January 7, 2025 08:47
Copy link

sonarqubecloud bot commented Jan 7, 2025

@johannaengland johannaengland merged commit e1b3474 into Uninett:master Jan 7, 2025
14 checks passed
@johannaengland johannaengland deleted the tox/add-rule-docs branch January 7, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a rule to tox.ini to build the sphinx documentation
3 participants