Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rudimentary notificationprofile support #1095

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

hmpf
Copy link
Contributor

@hmpf hmpf commented Dec 17, 2024

Same technique used as for timeslots, very fugly, but will take less work to look good!

@hmpf hmpf added the frontend Affects frontend label Dec 17, 2024
@hmpf hmpf self-assigned this Dec 17, 2024
@hmpf hmpf requested review from podliashanyk and a team December 17, 2024 09:55
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 55.76923% with 23 lines in your changes missing coverage. Please review.

Project coverage is 79.82%. Comparing base (c259f98) to head (6ebbba5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/argus/htmx/notificationprofile/views.py 54.90% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
- Coverage   80.04%   79.82%   -0.22%     
==========================================
  Files         143      144       +1     
  Lines        5206     5250      +44     
==========================================
+ Hits         4167     4191      +24     
- Misses       1039     1059      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delivers what it promises. Agree with a list of todos in #1095 (comment), we need separate issues for them. See some suggestions, typo fixes below.

Also tested it manually and it works mostly as expected, except wrong urls in some buttons (see typo fixes below) and a bug: it is possible to create profile with no destinations.

Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See a little cleanup below. Also styles.css seem to need an update

@hmpf hmpf requested a review from podliashanyk December 18, 2024 10:54
Copy link
Contributor

@podliashanyk podliashanyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! 🙌
Can be merged after updated styles are cleaned up a little. Seems like there is a bunch of breadcrumbs styles added yet we don't use them in this PR yet.

@hmpf hmpf force-pushed the add-rudimentary-notificationprofiles-page branch from 3846182 to 6ebbba5 Compare December 18, 2024 11:04
@hmpf
Copy link
Contributor Author

hmpf commented Dec 18, 2024

Can be merged after updated styles are cleaned up a little. Seems like there is a bunch of breadcrumbs styles added yet we don't use them in this PR yet.

There are breadcrumbs-classes in use, in the admin, see
src/argus/incident/templates/incident/admin/fake_incident_add_form.html.

Unless there is a way to make tailwind ignore some templates I think we are stuck with this.

@podliashanyk
Copy link
Contributor

Can be merged after updated styles are cleaned up a little. Seems like there is a bunch of breadcrumbs styles added yet we don't use them in this PR yet.

There are breadcrumbs-classes in use, in the admin, see src/argus/incident/templates/incident/admin/fake_incident_add_form.html.

Unless there is a way to make tailwind ignore some templates I think we are stuck with this.

Oh right.. Seems like an update of projectPaths in tailwind.config.js is needed after merging of repos

@hmpf hmpf merged commit 58f1535 into Uninett:master Dec 18, 2024
24 checks passed
@hmpf hmpf deleted the add-rudimentary-notificationprofiles-page branch December 18, 2024 11:24
@hmpf hmpf mentioned this pull request Jan 6, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Affects frontend
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants