-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ruff more verbose #1084
Make ruff more verbose #1084
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1084 +/- ##
=======================================
Coverage 81.18% 81.18%
=======================================
Files 140 140
Lines 5076 5076
=======================================
Hits 4121 4121
Misses 955 955 ☔ View full report in Codecov by Sentry. |
question though, if the statistics flag doesn't exist anymore, why did it still shorten the output? |
I have no idea. Removing it fixed the problem, and I couldn't find it described in the ruff docs. (If I run my locally installed It's not mentioned anywhere that (some?) |
I don't get from this PR what it actually fixes. Was any pre-commit run failing? What was the output? https://docs.astral.sh/ruff/configuration/#full-command-line-interface -
|
Yeah, so that output is not helpful for a developer. They (or at least: I) want to see which files and which lines are not passing so that they can have a look manually. With the statistics flag that's very hard to figure out |
That makes sense, then I will just amend the body of this PR to clarify this |
In ruff
--output-format=full
is the default.And the
statistics
flag shortens the output too much to be helpful when developing