Skip to content

Commit

Permalink
Declare color scheme for themes without them
Browse files Browse the repository at this point in the history
* Declare argus theme as a light color scheme
* Declare the example theme in the docs as a dark color scheme

Ensures we always have a reasonable fallback regardless of what the user's default OS color scheme is. Otherwise inappropriate fallbacks might be applied, like e.g. dark background color for input fields where the theme is light but the OS/browser is using darkmode, and vice versa.
  • Loading branch information
podliashanyk authored Dec 13, 2024
1 parent dc51a6c commit f08319f
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 304 deletions.
1 change: 1 addition & 0 deletions changelog.d/1088.changed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Declared argus-theme as one with the light color scheme in order to awlays have reasonable fallbacks.
1 change: 1 addition & 0 deletions changelog.d/1088.fixed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed background color in input fields for argus-theme globally.
1 change: 1 addition & 0 deletions docs/customization/htmx-frontend.rst
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ How to customize the look:
"dim",
"autumn",
{ "mytheme": {
"color-scheme": "dark",
"primary": "#009eb6",
"primary-content": "#00090c",
"secondary": "#00ac00",
Expand Down
1 change: 1 addition & 0 deletions src/argus/htmx/defaults.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"light",
{
"argus": {
"color-scheme": "light",
"primary": "#006d91",
"primary-content": "#d1e1e9",
"secondary": "#f3b61f",
Expand Down
Loading

0 comments on commit f08319f

Please sign in to comment.