Fix HTMX destination forms not allowing same label across different m…

…edia
Uninett · Dec 10, 2024 · 103abb6 · 103abb6
1 parent 6f30c88
commit 103abb6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelog.d/1075.fixed.md b/changelog.d/1075.fixed.md
@@ -0,0 +1 @@
+Fix bug that made it so the HTMX destinations forms did not allow DestinationConfigs with different medias to have the same label.
diff --git a/src/argus/htmx/destination/forms.py b/src/argus/htmx/destination/forms.py
@@ -67,7 +67,7 @@ def _validate_serializer(self):
                 self.cleaned_data["settings"] = settings
 
         if label := self.cleaned_data.get("label"):
-            destination_filter = DestinationConfig.objects.filter(label=label)
+            destination_filter = DestinationConfig.objects.filter(label=label, media=media)
             if self.instance:
                 destination_filter = destination_filter.exclude(pk=self.instance.pk)
             if destination_filter.exists():
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix bug that made it so the HTMX destinations forms did not allow DestinationConfigs with different medias to have the same label.