Fix NcmlReader.mergeNcml with groups #1404
Merged
+76
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure reference group is passed into readGroup when using NcmlReader.mergeNcml, and make sure the reference group information is taken into account by the readGroup code. Fixes Unidata#1403
modifyNestedGroups.xml is intended to apply to an already existing NetcdfDataset object using NcmlReader.wrapNcml, and isn't appropriate for use by the TestNcmlReadersComnpare test, which expects the NcML to fully define a dataset or reference one directly in the document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure reference group is passed into readGroup when using NcmlReader.mergeNcml, and make sure the reference group information is taken into account by the readGroup code.
Fixes #1403
PR Checklist
until ready for review