Modernize FFmpeg Codebase #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s09bQ5
reviewed
Jan 11, 2025
s09bQ5
approved these changes
Jan 11, 2025
|
Considering everything still builds and s09bQ5 has already approved this PR and complexlogic has tested it on more platforms than I can do myself, there's no point in me reviewing this further or letting it sit. I did have a look at the markdown changes, and those also all look fine. Better to get it into master and do a new release in February. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #939, this PR sets the minimum FFmpeg version to 4.0, and removes the obsolete legacy code from FFmpeg 3.x and earlier. This significantly improves the maintainability of the FFmpeg codebase.
This PR also makes libswscale and libswresample required instead of optional. The historical reasons for why they were made optional are no longer valid today, and it's fair to assume that anyone with an FFmpeg >= 4.0 package will have these libraries installed.
Besides the removals, the following code additions were made:
src/media/UMediaCore_FFMpeg.pas,TPacketQueue's StatusInfo functionality is fixed, which has been broken since ef52574. See @s09bQ5's commentsrc/media/UMediaCore_FFMpeg.pas, fixTMediaCore_FFmpeg.GetErrorString, which has been broken for the full Git historyI've successfully built and tested the changes in the following configurations:
Fixes #939