Feature/win parallel port #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add support for enumeration of parallelports. This is on the base class, as enumeration is platform specific This function needs to be implemented in derived classes.
…sy-lib into feature/win-parallel-port
PsyTimePoints are BoxedTypes, instead of instances of GObject. The code related to psy-parallel-trigger still used g_object_unref on them. This commit will call correctly psy_time_point_free on them. fixes #136
Sleep(1), will sleep at least 1 ms on windows, but in practice it sleeps for much longer e.g. +/- 10 times as long. For timing stuff accuratly, psylib needs to busyloop until that time arives. So in order to save energy, psylib sleeps for 1 ms until the event we are sleeping for is less then 1 ms away, and then it will start busy looping, until the event-time. The code in [class.ParallelTrigger] was fine, however, it overslept because Sleep issue mentionned above. Now TimeBeginPeriod is called when initializing psylib and TimeEndPeriod is called when deinitialiing psylib This fixes #137
maartenuni
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a ParallelPort trigger interface for windows.