Update/dsc 3 #150
Merged
Update/dsc 3 #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be the bulk of the (essential) work needed; it does need a final pass for the Django 4 upgrade, and the mailing stuff needs to be migrated as well
Addresses more of #86
# Conflicts: # api/templates/api/mail/new_appointment_timeslot.html # api/templates/api/mail/new_appointment_timeslot.txt # api/utils/appointment_mail.py # api/utils/create_participant_account.py # experiments/models/experiment_models.py # experiments/templates/experiments/mail/invite.html # experiments/templates/experiments/mail/invite.txt # experiments/utils/invite.py # experiments/utils/remind_participant.py # main/locale/en/LC_MESSAGES/django.po # main/locale/nl/LC_MESSAGES/django.po # requirements.txt
# Conflicts: # experiments/templates/experiments/mail/invite.html
# Conflicts: # participants/utils/merge_participants.py
Might fix #143
# Conflicts: # api/utils/appointment_mail.py # api/utils/cancel_appointment.py # api/utils/create_participant_account.py # experiments/utils/invite.py # experiments/utils/participant_subscription.py # experiments/utils/remind_participant.py # requirements.txt
How did I get it so wrong? Fixes #147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow no conflicts?