Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured Grid Reader #1040

Merged
merged 22 commits into from
Oct 30, 2024
Merged

Structured Grid Reader #1040

merged 22 commits into from
Oct 30, 2024

Conversation

philipc2
Copy link
Member

@philipc2 philipc2 commented Oct 24, 2024 •
edited
Loading

Closes #725 #1044 #1043

Overview

  • Adds support for reading structured grids and representing them as unstructured grids.
  • User guide notebook

@philipc2 philipc2 self-assigned this Oct 24, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@philipc2 philipc2 linked an issue Oct 24, 2024 that may be closed by this pull request
Ability to Represent Structured Grids #725
Closed
This was linked to issues Oct 28, 2024
Implement Grid.from_structured() #1043
Closed
Implement UxDataset.from_structured() #1044
Closed
@philipc2 philipc2 changed the title DRAFT: Structured Grid Reader Structured Grid Reader Oct 28, 2024
@philipc2 philipc2 marked this pull request as ready for review October 28, 2024 19:43
@philipc2 philipc2 requested a review from rytam2 October 29, 2024 14:57
rytam2
rytam2 reviewed Oct 30, 2024
View reviewed changes
docs/user-guide/structured.ipynb Show resolved Hide resolved
docs/user-guide/structured.ipynb Show resolved Hide resolved
docs/user-guide/structured.ipynb Show resolved Hide resolved
rytam2
rytam2 reviewed Oct 30, 2024
View reviewed changes
docs/userguide.rst Outdated Show resolved Hide resolved
rytam2
rytam2 reviewed Oct 30, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
rytam2
rytam2 reviewed Oct 30, 2024
View reviewed changes
uxarray/io/_structured.py Outdated Show resolved Hide resolved
@philipc2 philipc2 requested a review from rytam2 October 30, 2024 16:21
aaronzedwick
aaronzedwick approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@aaronzedwick aaronzedwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome Philip, this is a great addition to have. The user notebook looks really good too, I think it came out really nicely.

rytam2
rytam2 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@rytam2 rytam2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work looks really good. Great job Philip!

@philipc2 philipc2 merged commit 948b0f5 into main Oct 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytam2 rytam2 rytam2 approved these changes

@aaronzedwick aaronzedwick aaronzedwick approved these changes

@rajeeja rajeeja Awaiting requested review from rajeeja

@erogluorhan erogluorhan Awaiting requested review from erogluorhan

Assignees

@philipc2 philipc2

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@philipc2 @aaronzedwick @rytam2