Gurvir - WARG Autonomy Bootcamp #131
Conversation
| if result: | ||
| bounding_boxes.append(box) |
There was a problem hiding this comment.
Normally in statistics, if one part (one of the bounding boxes) of the data (the entire image) is invalid, we discard the entire data point.
(You do not need to change anything here, just something to think about)
| if not self.has_sent_landing_command and report.status == drone_status.DroneStatus.HALTED: | ||
|
|
||
| # If the drone is halted, start the move command | ||
| command = self.commands |
There was a problem hiding this comment.
I don't think self.commands is defined anywhere
|
|
||
| # If the drone is halted, start the move command | ||
| command = self.commands | ||
| self.has_sent_landing_command = True |
There was a problem hiding this comment.
Please rename this variable to has_sent_move_command, because your comments indicate that you sent a move command and not a landing command. It's very confusing that you're setting has_sent_landing_command to True
| self.move_command = commands.Command.create_set_relative_destination_command( | ||
| self.destination_x, self.waypoint.location_y | ||
| ) |
There was a problem hiding this comment.
Not sure what this is for? It is never used. Also, this move command is based on relative distance, so you need to take into account your current position
| command = move_command | ||
| self.has_sent_move_command = True | ||
|
|
||
| elif distance_squared < acceptance_radius_squared and self.has_sent_move_command is True: |
There was a problem hiding this comment.
This is fine for this bootcamp, but what happens if the drone halts unexpectedly midway in the flight? (Just something to think about, you do not need to change anything)
No description provided.