Improve Unit Test Coverage and Cache Functionality for QuoteScraper #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Add SWOC and a BEGINNER label to this PR! and Don't forget to Update points to SWOC leaderboard
Summary:
This PR introduces improvements to the testing suite for the
QuoteScraper
class. It refines the existing unit tests, ensuring better handling of dynamic fields, better test coverage, and improved reliability of the tests.Detailed Changes:
test_parse_quote_element_valid
:scraped_at
field when comparing the expected and actualQuote
objects, ensuring a stable comparison for the remaining fields.test_parse_quote_element_missing_author
:None
.test_cache_functionality
:load_cache
) and saving (save_cache
) methods to verify that cached quotes are correctly reused and updated during scraping.test_parse_quote_element_with_datetime_mock
:datetime.now()
to return a fixed timestamp, ensuring that tests involvingscraped_at
are consistent and deterministic.test_fetch_page_failure
: