Bug/bidirectional search #466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly! Feel free to join our community on Discord to discuss more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #465
Description
This pull request addresses the issue with the
bidirectional_searchfunction inalgorithms/bidirectional_bfs.py, which currently fails to return the correct (i.e. shortest) path between the start and target nodes. The algorithm itself executes but returns incorrect results, as highlighted by the failing test test_path inTests/algorithms/test_bidirectional_bfs.py.Fix: This PR reverts the implementation of bidirectional_search to an earlier, correct version (as seen in PR #322). The updated code ensures the correct calculation of the shortest path between the start and target nodes, and it successfully passes the test_path test.
Testing:
After implementing the fix, I ran test_path and verified that it now passes as expected with the correct shortest path.