Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding travel grant information #46

Merged
merged 4 commits into from
May 22, 2024
Merged

adding travel grant information #46

merged 4 commits into from
May 22, 2024

Conversation

jrgochan
Copy link
Collaborator

Description

Checklist:

  • (Committee Chairs Only) I have posted the link for the PR in the usrse slack (#usrse-2024-conference-planning-committee) to ask for content reviewers
  • I have previewed changes locally
  • I have updated the README.md if necessary

cc ADD GITHUB HANDLES HERE
@jsubida

@jrgochan jrgochan requested review from jsubida and mrmundt May 20, 2024 21:06
@jrgochan jrgochan marked this pull request as ready for review May 20, 2024 21:07
jrgochan
jrgochan commented May 20, 2024
View reviewed changes
Copy link
Collaborator Author

@jrgochan jrgochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I am making many mistakes.

@jrgochan jrgochan removed request for jsubida and mrmundt May 20, 2024 21:23
mrmundt
mrmundt requested changes May 20, 2024
View reviewed changes
pages/attend/travel.md Outdated Show resolved Hide resolved
pages/attend/travel.md Outdated Show resolved Hide resolved
pages/attend/travel.md Outdated Show resolved Hide resolved
jrgochan
jrgochan commented May 20, 2024
View reviewed changes
Copy link
Collaborator Author

@jrgochan jrgochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@KristinaRiemer
Copy link
Collaborator

Same! Any last improvements @mrmundt?

@jsubida
Copy link
Collaborator

jsubida commented May 21, 2024

I feel like I am making many mistakes.

"You really can't make a mistake here. Pull requests may or may not reveal happy accidents." - maybe Bob Ross if he did code

mrmundt
mrmundt reviewed May 22, 2024
View reviewed changes
.vscode/extensions.json Outdated Show resolved Hide resolved
@jsubida
Add .vscode to .gitignore
58d443c 
- Remove .vscode folder
@jsubida jsubida requested a review from mrmundt May 22, 2024 16:01
@mrmundt mrmundt merged commit d0bd2ce into main May 22, 2024
2 checks passed
@mrmundt mrmundt deleted the jrgochan/issue45 branch August 10, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmilechin lmilechin lmilechin left review comments

@KristinaRiemer KristinaRiemer KristinaRiemer left review comments

@danielskatz danielskatz danielskatz left review comments

@jsubida jsubida jsubida left review comments

@mrmundt mrmundt mrmundt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jrgochan @KristinaRiemer @jsubida @danielskatz @lmilechin @mrmundt @fluxview