Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:GetComment #12

Closed
wants to merge 6 commits into from
Closed

feat:GetComment #12

wants to merge 6 commits into from

Conversation

Chan-Heee
Copy link
Contributor

πŸ“Œ κ΄€λ ¨ 이슈 Issue

κ΄€λ ¨λœ 이슈의 번호 및 λ‚΄μš©

#11 κ²Œμ‹œκΈ€ λŒ“κΈ€ 쑰회

πŸ“š μž‘μ—… λ‚΄μš©


πŸ“ 상세 μ„€λͺ…

일단 첫pr ν…ŒμŠ€νŠΈκ²Έ ν•œκ°œλ§Œ κ΅¬ν˜„ν•˜κ³  λ³΄λ‚΄λ΄…λ‹ˆλ‹€.. μ΄λŸ°μ‹μœΌλ‘œ μ­‰ν•˜λ©΄ λ˜λŠ”μ§€μ™€ μˆ˜μ •λΆ€λΆ„ λ“± 지적 κ°μ‚¬νžˆλ°›κ² μŠ΅λ‹ˆλ‹€^^ λ‹€μŒ pr은 ν•œλ²ˆμ— 많이 보내도둝 ν•˜κ² μλ‹ˆλ‹Ή

haen-su
haen-su reviewed Jan 17, 2023
View reviewed changes
src/main/java/server/comment/domain/Comment.java Outdated
@@ -36,5 +37,6 @@ public class Comment extends BaseEntity {
private String content;

private int likeNumber;
private LocalDateTime registerTime;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 μ–΄λ–€ μ˜λ―ΈμΈκ°€μš©?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GUI λ³΄λ‹ˆκΉŒ λŒ“κΈ€ μž‘μ„± μ‹œκ°„ 있길래 λ„£μ—ˆμ–΄μš”

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ‹œκ°„μ€ BaseTimeEntity에 μžˆμ–΄μ„œ 빼도될 κ±° κ°™μ•„μš”

src/main/java/server/comment/repository/CommentRepository.java Outdated
"FROM comment " +
"WHERE post_id = :postId",
nativeQuery = true)
List<Comment> findByPostId(@Param("articleId") Long postId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이뢀뢄 articleId μ•„λ‹ˆκ³  postId μ•„λ‹Œκ°€μš€?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μ³€μŠ΄λ‹Ή

src/main/java/server/comment/dto/CommentDto.java Outdated
import java.time.LocalDateTime;

@AllArgsConstructor
@NoArgsConstructor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createCommentDto λ©”μ„œλ“œ μžˆλŠ”λ° μš” μœ„μ— μ–΄λ…Έν…Œμ΄μ…˜ λ‘κ°œ μΆ”κ°€ν•œ μ΄μœ κ°€ λ¬΄μ—‡μΈκ°€μš”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 써놓고 λ΄€λŠ”λ° 빼도 될것 κ°™λ„€μš”

@haen-su haen-su closed this Jan 17, 2023
@haen-su haen-su deleted the feat/GetComment branch January 18, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haen-su haen-su haen-su left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chan-Heee @haen-su