HPC: Fix port checking #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the issue where a job would sometimes fail to start the model server due to the port being occupied.
Details
lsofwas used to determine whether a port is free or not. However, without root permissionslsofcan only show open connections for the user who ran the command (i.e. not for all the other users on the HPC cluster).Warning
There is still a race condition that can occur in the time frame between the job script checking the port and the model server actually occupying it. However, I didn't encounter this issue yet during my tests and fixing it would require some major changes to the UM-Bridge interface used for serving models.
Related Issues
closes #83, closes #48