Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
cmake
to the root. This folder contains two configuration filesUmbridgeConfig.cmake
allows to use the repository directlyUmbridgeConfig.cmake.in
will be installed when using cmake (and the corresponding CMakeLists.txt)This way, cmake users can install the library using
As this lib provides
json.hpp
andhttplib.h
, I suggest to reorganize the code a little bit tosuch the client would include
umbridge/umbridge.h
. This way you can ship your own json and httplib without getting conflicts with system providedjson.h
andhttplib.h
What do you think?