Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PROPERTIES to set a default value, and Modules to auto-initialise their DF columns to these values #1436

Merged
merged 15 commits into from
Sep 10, 2024
Merged

Allow PROPERTIES to set a default value, and Modules to auto-initialise their DF columns to these values #1436

merged 15 commits into from
Sep 10, 2024

Commits on Jul 29, 2024

  1. Typehints and general implementation for initialise_population

    @willGraham01
    willGraham01 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    e71a5a3 View commit details
    Browse the repository at this point in the history

  2. Allow CATEGORICAL Properties to be assigned a default value from the … 

    …set of Categories, and add class typehints to Property and Module
    @willGraham01
    willGraham01 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    7a6657f View commit details
    Browse the repository at this point in the history

  3. Allow all PROPERTY types to have default values

    @willGraham01
    willGraham01 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b25be80 View commit details
    Browse the repository at this point in the history

  4. Clarify default value usage in docstring

    @willGraham01
    willGraham01 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d3cb3ce View commit details
    Browse the repository at this point in the history

  5. Expand initialise_population docstring to describe usage cases

    @willGraham01
    willGraham01 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d93cb32 View commit details
    Browse the repository at this point in the history

  6. Linting pass

    @willGraham01
    willGraham01 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    5b240bd View commit details
    Browse the repository at this point in the history

  7. Give default_value a setter

    @willGraham01
    willGraham01 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    051080a View commit details
    Browse the repository at this point in the history

  8. Move relevant parts of docstring to default_value setter from init

    @willGraham01
    willGraham01 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    dce3477 View commit details
    Browse the repository at this point in the history

  9. _default_name is public-facing across modules. Revert from default_na… 

    …me to avoid touching multiple modules
    @willGraham01
    willGraham01 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    58aa73e View commit details
    Browse the repository at this point in the history

  10. Fix logic error in setting defaults.

    @willGraham01
    willGraham01 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    032878c View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Matt Graham <[email protected]>
    @willGraham01 @matt-graham
    willGraham01 and matt-graham authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b0d81cb View commit details
    Browse the repository at this point in the history

  2. Review comments that can't be done on GitHub's API

    @willGraham01
    willGraham01 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    40f7c35 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into wgraham/initialise-properties-by-default

    @willGraham01
    willGraham01 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    36ae9b7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into wgraham/initialise-properties-by-default

    @willGraham01
    willGraham01 authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    9069ad2 View commit details
    Browse the repository at this point in the history

  5. Linting one import line

    @willGraham01
    willGraham01 authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4334a3e View commit details
    Browse the repository at this point in the history