-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use listmode time frame for output frame definition if all events are used #1519
Conversation
… throwing a warning otherwise
Co-authored-by: Kris Thielemans <[email protected]>
most jobs were ok, but one Also, clang-format issues. |
Can be reproduced by using the following .par file
and
which results in
This is probably due to the fact that the |
The ROOT job worked fine, but I've cancelled the rest of the workflow as the merge commit will run everything again anyway. Hopefully that'll work ok. |
documentation/release_6.3.htm
Outdated
</li> | ||
<li> | ||
<tt>stir_timings</tt> has now an extra option to parse a par-file for a projector-pair. | ||
</li> | ||
<li> | ||
Duration in sinogram interfile/exam_info obtained from lm_to_projdata has the correct value if we unlist all the events. This is not true for Root files | ||
<a href=https://github.com/UCL/STIR/pull/1503>PR #1503</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be 1519. Also, please use ROOT, use <tt>lm_to_projdata</tt>
and put a <br>
after that line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! squash-merge ok here? (we went back-and-forth a bit).
sure |
… used (UCL#1519) use the time frame information (where available) for the listmode data to set the frame definition for the output of LmToProjData if all events are used, issuing a warning otherwise --------- Co-authored-by: Kris Thielemans <[email protected]>
use interfile information for frame difinition if all event are used,… throwing a warning otherwise
Changes in this pull request
use interfile information for frame difinition if all event are used,… throwing a warning otherwise
Testing performed
yes
Related issues
--fixes #1512
Checklist before requesting a review
documentation/release_XXX.md
has been updated with any functionality change (if applicable)