fixing geometrical factors #1132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only saves half of the data. This does not work when the number of detecors per block is odd. The branch fixes this: - save the whole data - apply symmetries anyway to reduce noise
|
the tests run OK and normalisation file created with the old version are the same |
|
Appveyor failure was my fault and is hopefully mixed on Probably best to do undo some white-space changes as well. I haven't reviewed the actual code yet. |
|
somehow not all the spaces I changed were modified as I was expecting |
|
not sure if I changed something wrong but this is not working anymore |
actually my branch was wrong in my computer this version does provide the same results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
estimation of geometrical factors uses mirroring and symmetries and only saves half of the data. This does not work when the number of detectors per block is odd. The branch fixes this: