Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MongoDB in CI Flow #167

Closed
wants to merge 6 commits into from
Closed

Conversation

hhenry01
Copy link
Member

Description

  • Resolves #issue

Verification

  • [ ]

Resources

@hhenry01 hhenry01 added the sim Boat Simulator team label Sep 13, 2023
@hhenry01 hhenry01 self-assigned this Sep 13, 2023
@hhenry01 hhenry01 marked this pull request as ready for review September 13, 2023 21:13
@hhenry01
Copy link
Member Author

@patrick-5546 do you think this is sufficient? I'm not really sure how to test it with mongodb related tests in subteam repos without having it enabled in sailbot_workspace's main branch first.

@hhenry01 hhenry01 enabled auto-merge (squash) September 13, 2023 21:15
@patrick-5546
Copy link
Member

patrick-5546 commented Sep 13, 2023

devcontainer.json is not used by CI.

The CI runs a single docker container

name: 'Test'
description: 'Test using devcontainer'
runs:
using: 'docker'
image: '../../../.devcontainer/Dockerfile'
entrypoint: ".github/actions/test/run.sh"

Maybe we could use/reference something like this? https://github.com/marketplace/actions/mongodb-in-github-actions

@hhenry01 hhenry01 marked this pull request as draft September 14, 2023 22:04
auto-merge was automatically disabled September 14, 2023 22:04

Pull request was converted to draft

@hhenry01 hhenry01 force-pushed the user/hhenry01/enable-docker-ci branch 3 times, most recently from e9445ee to 82a427a Compare September 14, 2023 23:34
@hhenry01 hhenry01 force-pushed the user/hhenry01/enable-docker-ci branch 5 times, most recently from dd3a3c0 to bb1c6ae Compare September 15, 2023 00:32
@hhenry01 hhenry01 force-pushed the user/hhenry01/enable-docker-ci branch 10 times, most recently from 4a1ac30 to c23ce28 Compare September 23, 2023 18:09
@hhenry01 hhenry01 force-pushed the user/hhenry01/enable-docker-ci branch 4 times, most recently from 2fcc582 to dacdc2f Compare September 30, 2023 18:20
@hhenry01 hhenry01 force-pushed the user/hhenry01/enable-docker-ci branch from dacdc2f to 8852d74 Compare September 30, 2023 18:23
@patrick-5546
Copy link
Member

@patrick-5546 patrick-5546 deleted the user/hhenry01/enable-docker-ci branch October 3, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure sim Boat Simulator team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants