-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure mypy in workspace #156
Conversation
* Add path to python interpreter for black formatter * Add python interpreter path to isort and flake8 config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converted to draft, see To Dos in PR description
I think we have to run mypy in every directory that we want inside src rather than just at src like the other linters:
|
@DFriend01 for reference, here is how I resolved the errors in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay we did it
Description
mypy
in base container and create vscode tasktype check
To Do
ament_mypy src
in the terminalIf still getting errors with extension, remove from devcontainer.jsonOnce this is merged, create a new minor release
Verification