Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add An Interfaces Submodule Instead of Submodule Per Interface #15

Merged
merged 5 commits into from
Jan 21, 2024

Conversation

CihanBosnali
Copy link
Member

No description provided.

CihanBosnali and others added 5 commits January 9, 2024 19:58
* Create WebSocket for Webcam Interface (#9)

* Added websocket prototype using websocket++

* Update CXXFLAGS to be more specific

* Update BUILD_GUIDE dependencies

Added 'WebSocket++' and 'boost' to the list of additional dependencies in BUILD_GUIDE.md.

* Remove header files

* Add variables for Websocketpp and Boost libraries

* Update path for Websocketpp and Boost

* Update build guide

* Prevent server from crashing when the client abruptly closes the connection

* Update docs

* Remove std::

* Downgrade to c++17

* Add Build and Test GitHub Action

* Rename workflow

* separated the webcam module into web and webcam modules (#12)

* Webcam Plant Detection (#13)

* changes for webCam

* Added hpp file, minor style fixes, deleted output files

---------
Co-authored-by: emilysxng
Co-authored-by: CihanBosnali <[email protected]>

---------

Co-authored-by: Asad Dhorajiwala <[email protected]>
Co-authored-by: Alfredo-del-Rayo <[email protected]>
Co-authored-by: droy4405 <[email protected]>
Copy link
Contributor

@Tortus-exe Tortus-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are minimal. Subsequent builds should not be affected, and if necessary more submodules can be created. Build guide updates are useful, and although the changes can be made redundant depending on the package manager, redundancy never hurt anyone.

@Tortus-exe Tortus-exe merged commit 9c8d369 into main Jan 21, 2024
2 checks passed
@Tortus-exe Tortus-exe deleted the system-design-cihan branch January 21, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants