Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD fix for PDBijector #280
AD fix for PDBijector #280
Changes from 16 commits
3967e39
394debc
64d87bf
d175513
94f6a0e
83fee94
4b390c6
1185cad
6be9534
7675ea2
15c47eb
9322fda
0bf8487
5d0cd2d
29790dc
3241936
951028e
4fe6085
1102266
4e66a8d
4f1ecc8
e87a2aa
52ee210
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the last remaining question @devmotion . I'm thinking "let's not, until we start using it"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrap in
Hermitian
to effectively do the same as the current implementation ofcholesky_factor
but I believecholesky(::Hermitian)
is only valid starting from Julia 1.8 (going by a comment in BijectorsReverseDiffExt), so we need to fix this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually not a problem anymore since we're now defining the adjoint to circumvent the
cholesky
on tracked completely.