Fix lineOffset spherical geometry errors (fix #2278) #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 8, 2022 23:23
Project geometries to Azimuthal Equidistant projection prior to transformation and then back to WGS84
Use correct geometry types correct import Use coordinates rather than the geometry object
Simage
changed the title
Simage
changed the title
|
@rowanwins perhaps the best person to weigh in on this? It seems sensible to me but perhaps there's side effects I'm not seeing |
|
This PR might help in some circumstances but I don't think it will resolve some of the bigger underlying issues unfortunantly (eg #1439). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project geometries to Azimuthal Equidistant projection prior to transformation and then back to WGS84.
There is an earlier similar PR however it has a unique implementation whereas this implementation duplicates the projection code from the buffer implementation. Ideally, this projection code would eventually be refactored into a utility and maintained in a single location