Prune the list of trusted fetch origins #791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub, GitLab, and Bitbucket pages allow redirects to untrusted sources Itch and GameJolt really shouldn't have been on this list in the first place. We don't actually trust them.
|
This is a really frustrating pull request |
This comment was marked as spam.
This comment was marked as spam.
|
raw.githubusercontent.com remains trusted GitHub Pages and friends unfortunately allow redirects to other (untrusted) sites |
That does not resolve the fact that some extensions will look dangerous to unknowing users when they really aren't. The problem comes from blocks that let you redirect. The solution is to put a blanket warning on all redirects, no? Unless I'm not seeing the bigger picture |
|
Itch, GameJolt, and ScratchDB will be re-added to the list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub, GitLab, and Bitbucket pages allow redirects to untrusted sources. Itch and GameJolt really shouldn't have been on this list in the first place.