generator for honeybadger #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolprobn
requested changes
May 6, 2024
| end | ||
|
|
||
| def display_alert_message | ||
| if options[:use_env_variable] |
There was a problem hiding this comment.
Need to fix this by looking at previous comments in other PRs
| app_path | ||
| end | ||
|
|
||
| def test_should_add_honeybadger_gem |
There was a problem hiding this comment.
Let's update to "test_should_configure_honeybadger"
| end | ||
| end | ||
|
|
||
| def test_should_configure_honeybadger_gem_to_use_env_variable |
There was a problem hiding this comment.
Let's update to "test_should_use_env_variable_for_api_key"
coolprobn
approved these changes
May 7, 2024
mausamp
force-pushed
the
generator-for-honeybadger
branch
from
99c73ad to
d108121
Compare
mausamp
force-pushed
the
generator-for-honeybadger
branch
from
d108121 to
1fc4fd9
Compare
coolprobn
force-pushed
the
generator-for-honeybadger
branch
2 times, most recently
from
c46407f to
37b52d0
Compare
coolprobn
force-pushed
the
generator-for-honeybadger
branch
from
37b52d0 to
e632993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.