Fix generatorRadial wonkiness #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes when the DimSum ticked over, the generatorRadial would animate backwards, awkwardly speed up and slow down, or otherwise jump around a bit. This fixes that by creating a rotation matrix directly, rather than worrying about animating a "degrees" value that's being restricted to [0,360)...
|
Disregard this for now; it doesn't actually work, it just moves the problem =\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when the DimSum ticked over, the generatorRadial would animate
backwards, awkwardly speed up and slow down, or otherwise jump around a bit.
This fixes that by creating a rotation matrix directly, rather than worrying
about animating a "degrees" value that's being restricted to [0,360)...