New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/a11y improvements #947

Closed

mryunt02 wants to merge 2 commits into Trendyol:next from mryunt02:feature/a11y-improvements

Contributor

mryunt02 commented Oct 18, 2024

Changes Made For accessibility(a11y):

Dialog: label added to button(close icon)
Drawer: label added to button(close icon)
Progress Indicator: aria-label: "progress indicator" added
Radio: It's now focusable and keyboard events added:

private handleKeyDown = (event: KeyboardEvent) => {
    if (event.key === "Enter" || event.key === " ") {
      event.preventDefault();
      this.select();
    }
  };

also aria-checked=${this.selected} added

mryunt02 added 2 commits

October 19, 2024 01:38


          feat(checkbox): Add keyboard handling for Enter and Space keys to tog…

3a22ca0

…gle checked state


          feat(a11y): Accessibility improvements for Dialog, Drawer, Progress I…

df749a4

…ndicator and Radio

mryunt02 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet